Question

How to check if integer addition will overflow in C++

Answer 1

#include <iostream>
#include <climits>

bool addingWillOverflow(int x, int y) {
    return ((x > 0) && (y > INT_MAX - x)) || ((x < 0) && (y < INT_MIN - x));
}

bool willAdditionOverflowUnsigned(unsigned int x, unsigned int y) {
    return (x > UINT_MAX - y);
}

// Some compilers, like GCC or Clang, provide built-in functions to detect overflow
bool willAdditionOverflowBuiltin(int a, int b) {
    int result;
    return __builtin_add_overflow(a, b, &result);
}

int main() {
    int x = 38839299, y = 2372783642;
    std::cout << (addingWillOverflow(x, y) ? "true" : "false") << std::endl;

    x = 2438839299; y = 3972783642;
    std::cout << (addingWillOverflow(x, y) ? "true" : "false") << std::endl;

    unsigned int x1 = 138839299, y1 = 2372783642;
    std::cout << (willAdditionOverflowUnsigned(x1, y1) ? "true" : "false") << std::endl;

    x1 = 4238839299; y1 = 2372783642;
    std::cout << (willAdditionOverflowUnsigned(x1, y1) ? "true" : "false") << std::endl;

    std::cout << (willAdditionOverflowBuiltin(x, y) ? "true" : "false") << std::endl;
}



/*
run:

false
true
false
true
true

*/

 

70+ SQL courses for beginners and professionals

Answer 2

#include <iostream>
#include <limits>

bool addingWillOverflow(int x, int y) {
    return ((x > 0) && (y > std::numeric_limits<int>::max() - x)) || ((x < 0) && (y < std::numeric_limits<int>::min() - x));
}

bool willAdditionOverflowUnsigned(unsigned int x, unsigned int y) {
    return (x > std::numeric_limits<unsigned int>::max() - y);
}

// Some compilers, like GCC or Clang, provide built-in functions to detect overflow
bool willAdditionOverflowBuiltin(int a, int b) {
    int result;
    return __builtin_add_overflow(a, b, &result);
}

int main() {
    int x = 38839299, y = 2372783642;
    std::cout << (addingWillOverflow(x, y) ? "true" : "false") << std::endl;

    x = 2438839299; y = 3972783642;
    std::cout << (addingWillOverflow(x, y) ? "true" : "false") << std::endl;

    unsigned int x1 = 138839299, y1 = 2372783642;
    std::cout << (willAdditionOverflowUnsigned(x1, y1) ? "true" : "false") << std::endl;

    x1 = 4238839299; y1 = 2372783642;
    std::cout << (willAdditionOverflowUnsigned(x1, y1) ? "true" : "false") << std::endl;

    std::cout << (willAdditionOverflowBuiltin(x, y) ? "true" : "false") << std::endl;
}



/*
run:

false
true
false
true
true

*/

 

70+ SQL courses for beginners and professionals